Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devlocal login using email #2241

Merged
merged 3 commits into from Jun 7, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented Jun 6, 2019

Description

Several changes here:

  • Can log in as a user given an email address in a text box
  • Only users for the app that is being used are shown (ie no office users shown in service member site)
  • Only creation buttons exist for app that is being used (ie can't create TSP user from service member site)

This came up because I need to keep track of where I am in creating load testing personas by hand and logging back into them. However load testing can create 100s-1000s of users so I can never find them in the list to log in.

Setup

Go to each app and try out local sign in.

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • The requirements listed in
    Querying the Database Safely
    have been satisfied.
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

Screenshot

Screen Shot 2019-06-06 at 11 19 39 AM

@chrisgilmerproj chrisgilmerproj self-assigned this Jun 6, 2019

@chrisgilmerproj chrisgilmerproj referenced this pull request Jun 6, 2019

Open

Load testing with locust.io #1597

1 of 3 tasks complete
@jim

jim approved these changes Jun 7, 2019

Copy link
Contributor

left a comment

Nice upgrades! 🚀

@@ -142,31 +157,34 @@ func (h UserListHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
<form method="post" action="/devlocal-auth/new">

This comment has been minimized.

Copy link
@jim

jim Jun 7, 2019

Contributor

This looks like we could probably make a loop to create the app-specific forms. I'm pretty OK with it as-is though.

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Jun 7, 2019

Author Contributor

You're right:) That may come shortly if I touch this file again.

@chrisgilmerproj chrisgilmerproj merged commit b4fc6c8 into master Jun 7, 2019

17 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_devlocal_login_from_textbox branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.