Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to current practices #2244

Merged
merged 2 commits into from Jun 10, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Jun 6, 2019

Description

This document is woefully out of date and needs much help. Recently it also came to light that it's incomplete for people with little or no developer knowledge who may be starting from a fresh macbook. I've done a pretty quick and dirty fix for this in this PR.

@chrisgilmerproj chrisgilmerproj self-assigned this Jun 6, 2019

Remove comment about network dependencies not only because that secti…
…on was incomplete but because no one has really done this step
@codecov

This comment has been minimized.

Copy link

commented Jun 6, 2019

Codecov Report

Merging #2244 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
+ Coverage      59%   59.07%   +0.08%     
==========================================
  Files         250      250              
  Lines       14085    14094       +9     
==========================================
+ Hits         8310     8326      +16     
+ Misses       4774     4765       -9     
- Partials     1001     1003       +2
@garrettqmartin8
Copy link
Contributor

left a comment

LGTM - thanks @chrisgilmerproj

@kahlouie
Copy link
Contributor

left a comment

:shipit:

@chrisgilmerproj chrisgilmerproj merged commit cd028c0 into master Jun 10, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ba498bd...1566fe1
Details
codecov/project/go 58.89% (+0.08%) compared to ba498bd
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_fix_readme_steps branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.