Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for change in GOPATH #2245

Merged
merged 1 commit into from Jun 7, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Jun 6, 2019

Description

Recently changed the location of $GOPATH and we need to update our ADRs about it.

@@ -78,5 +78,6 @@ If you are looking to understand choices made in this project, see the list of [
* 0033 [*Service Object Layer*](adr/0033-service-object-layer.md#service-object-layer)
* 0034 [*Working With Mocks: Generation and Assertion*](adr/0034-working-with-mocks-generation-and-assertion.md#working-with-mocks-generation-and-assertion)
* 0035 [Use Query Builder for for Admin Interface](adr/0035-use-query-builder.md#use-query-builder-for-for-admin-interface)
* 0037 [Put mymove outside of standard GOPATH](adr/0037-go-path-and-project-layout-revisited.md#put-mymove-outside-of-standard-gopath)

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Jun 6, 2019

Author Contributor

There's another PR for ADR0036.

@codecov

This comment has been minimized.

Copy link

commented Jun 6, 2019

Codecov Report

Merging #2245 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
+ Coverage      59%   59.08%   +0.08%     
==========================================
  Files         250      251       +1     
  Lines       14085    14123      +38     
==========================================
+ Hits         8310     8344      +34     
- Misses       4774     4776       +2     
- Partials     1001     1003       +2
@mikena-truss
Copy link
Contributor

left a comment

Nit comments, but approving overall. Thanks for documenting this!


This choice had implications for other tools that the project uses like `pre-commit` hooks that use golang libraries. As seen in
[PR 2236](https://github.com/transcom/mymove/pull/2236) the interaction made it impossible to develop the project and
thus people `GO111MODULE=auto` was set and people were asked to move their repository outside of `$GOPATH`. This also

This comment has been minimized.

Copy link
@mikena-truss

mikena-truss Jun 7, 2019

Contributor

"thus people set GO111MODULE=auto and were asked"

Show resolved Hide resolved docs/adr/0037-go-path-and-project-layout-revisited.md
@lynzt

lynzt approved these changes Jun 7, 2019

Copy link
Contributor

left a comment

A few random things, but LGTM... 🚢

Show resolved Hide resolved docs/adr/0037-go-path-and-project-layout-revisited.md
MilMove adopted using the go module system as introduction in `go1.12` in [PR 1932](https://github.com/transcom/mymove/pull/1932).
This gave us the option of continuing to host our repository inside of `$GOPATH` or outside of `$GOPATH` and per
[ADR0003 Go Path and Project Layout](./0003-go-path-and-project-layout.md) the decision was to stay in `$GOPATH` and
set the environment variable `GO111MODULE=on` as a way of strictly enforcing go module behavior.

This comment has been minimized.

Copy link
@lynzt

lynzt Jun 7, 2019

Contributor

a link to more info about GO111MODULE?
like here (if this is the best location for info): https://github.com/golang/go/wiki/Modules

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Jun 7, 2019

Author Contributor

Yep, will add it!

@chrisgilmerproj chrisgilmerproj force-pushed the cg_gopath_adr branch from 1c7eadc to e32d539 Jun 7, 2019

@chrisgilmerproj chrisgilmerproj force-pushed the cg_gopath_adr branch from e32d539 to 3daecf0 Jun 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #2245 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
+ Coverage   58.93%   59.06%   +0.13%     
==========================================
  Files         252      253       +1     
  Lines       14273    14320      +47     
==========================================
+ Hits         8411     8458      +47     
  Misses       4850     4850              
  Partials     1012     1012

@chrisgilmerproj chrisgilmerproj merged commit 0079264 into master Jun 7, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f8c60ee...3daecf0
Details
codecov/project/go 58.89% (+0.14%) compared to f8c60ee
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_gopath_adr branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.