Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfilelint pre-commit hook #2248

Merged
merged 1 commit into from Jun 10, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented Jun 7, 2019

Description

This pre-commit hook uses https://github.com/replicatedhq/dockerfilelint to check our files. It's a nice little tool that I think adds some value.

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #2248 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2248      +/-   ##
==========================================
- Coverage   58.99%   58.91%   -0.08%     
==========================================
  Files         250      251       +1     
  Lines       14082    13997      -85     
==========================================
- Hits         8307     8246      -61     
+ Misses       4772     4757      -15     
+ Partials     1003      994       -9
@pjdufour-truss
Copy link
Contributor

left a comment

🚢

@chrisgilmerproj chrisgilmerproj merged commit e4486da into master Jun 10, 2019

18 of 19 checks passed

codecov/project/go 58.73% (-0.08%) compared to 7ae20d1
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7ae20d1...02647fc
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_dockerfilelint branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.