Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests changes to codecov file. Fix pre-commit script to spit out errors. #2249

Draft
wants to merge 1 commit into
base: master
from

Conversation

1 participant
@chrisgilmerproj
Copy link
Contributor

commented Jun 7, 2019

Description

I continually see failures for code changes that don't touch anything inside of pkg/. I'd like to correct that so we can start enforcing codecov as a tool. This branch is how I'll be testing things and I have an email out to Codecov Support to help me.

@chrisgilmerproj chrisgilmerproj self-assigned this Jun 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #2249 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2249     +/-   ##
========================================
+ Coverage    59.1%   59.1%   +0.1%     
========================================
  Files         254     251      -3     
  Lines       14349   14124    -225     
========================================
- Hits         8473    8345    -128     
+ Misses       4865    4776     -89     
+ Partials     1011    1003      -8
Impacted Files Coverage Δ
pkg/models/move_documents_extractor.go 80% <0%> (-10.9%) ⬇️
pkg/handlers/internalapi/move_documents.go 56.2% <0%> (-9.6%) ⬇️
pkg/models/user.go 70.6% <0%> (-5.9%) ⬇️
...ces/storage_in_transit/patch_storage_in_transit.go 73.6% <0%> (-1.4%) ⬇️
pkg/models/move_document.go 47% <0%> (ø) ⬆️
pkg/handlers/publicapi/api.go 0% <0%> (ø) ⬆️
pkg/handlers/internalapi/api.go 0% <0%> (ø) ⬆️
pkg/models/weight_ticket_set_document.go
...andlers/internalapi/weight_ticket_set_documents.go
pkg/services/postal_codes/validate_postal_code.go
... and 4 more

@chrisgilmerproj chrisgilmerproj force-pushed the cg_test_codecov_changes branch from 6d2a755 to 68c13a5 Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.