Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node-gyp problem #2250

Merged
merged 3 commits into from Jun 7, 2019

Conversation

2 participants
@chrisgilmerproj
Copy link
Contributor

commented Jun 7, 2019

Description

Recent changes to osx caused compiler issues with node-gyp. This is a dependency of node-sass and that in turn is modified by the setup of react-scripts. The solution here is to upgrade react-scripts to the latest version, which also means updating rescripts since that's what we use to modify react-scripts.

I've gone a little farther here and updated some things that caused us warnings:

  • babel-polyfill is deprecated and needs to be replaced by core-js and regenerator-runtime.
  • react-scripts no longer supports NODE_PATH being set. The issue here is that the jsconfig.json file was in the wrong directory and putting it in the root of our project helped fix things.
  • rescripts-env allows you to specify the exact rescripts you've added. We only use eslint so I've added a .rescriptsrc to do this which in turn speeds up builds since rescripts isn't scanning our repo for available changes to babel or typescript.

Setup

Check that everything builds correctly:

make clean client_build

Then run the website:

make client_run

Code Review Verification Steps

  • Request review from a member of a different team.

@chrisgilmerproj chrisgilmerproj self-assigned this Jun 7, 2019

@chrisgilmerproj chrisgilmerproj marked this pull request as ready for review Jun 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #2250 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2250      +/-   ##
==========================================
+ Coverage   59.03%   59.06%   +0.03%     
==========================================
  Files         252      253       +1     
  Lines       14290    14320      +30     
==========================================
+ Hits         8436     8458      +22     
- Misses       4844     4850       +6     
- Partials     1010     1012       +2
@tinyels

tinyels approved these changes Jun 7, 2019

Copy link
Contributor

left a comment

:shipit:

@chrisgilmerproj chrisgilmerproj merged commit 3c1d68a into master Jun 7, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 4015026...2a105bb
Details
codecov/project/go 58.89% (+0.03%) compared to 4015026
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_fix_node_gyp_problem branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.