Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore mnt directory and increase database timeout #2251

Merged
merged 1 commit into from Jun 10, 2019

Conversation

2 participants
@pjdufour-truss
Copy link
Contributor

commented Jun 7, 2019

Description

PR to ignore the mnt directory and add a database timeout. Want to get this in to decrease the likelihood of accidental commits of mnt.

Reviewer Notes

Is there anything you would like reviewers to give additional scrutiny?

Setup

None

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • The requirements listed in
    Querying the Database Safely
    have been satisfied.
  • Any new migrations/schema changes:
    • Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
    • Have been communicated to #dp3-engineering
    • Secure migrations have been tested using scripts/run-prod-migrations
  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
  • Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:
  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • User facing changes have been reviewed by design.
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

None

Screenshots

None

@pjdufour-truss pjdufour-truss changed the title Ignore mnt directory and add database timeout Ignore mnt directory and increase database timeout Jun 7, 2019

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #2251 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
+ Coverage   58.93%   59.06%   +0.13%     
==========================================
  Files         252      253       +1     
  Lines       14273    14320      +47     
==========================================
+ Hits         8411     8458      +47     
  Misses       4850     4850              
  Partials     1012     1012

@pjdufour-truss pjdufour-truss merged commit ab5fc0a into master Jun 10, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f8c60ee...1e9212a
Details
codecov/project/go 58.89% (+0.14%) compared to f8c60ee
Details

@pjdufour-truss pjdufour-truss deleted the gitignore_mnt branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.