Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TestYear for dates in testdatagen #2256

Merged
merged 1 commit into from Jun 14, 2019

Conversation

3 participants
@Igarfinkle
Copy link
Contributor

commented Jun 10, 2019

Description

Use TestYear in dates in testdatagen so dates don't creep away from TestYear and cause problems.

Reviewer Notes

To test, do I want to set TestYear back a few years, or forward a few years? I'm not sure how to check I've made all the right changes.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@Igarfinkle Igarfinkle requested review from jim and chrisgilmerproj Jun 10, 2019

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀 - Thanks for fixing tests!

@jim

jim approved these changes Jun 12, 2019

Copy link
Contributor

left a comment

🚛

@jim jim merged commit 0890cac into master Jun 14, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ba498bd...4d95319
Details
codecov/project/go 58.86% (+0.04%) compared to ba498bd
Details

@jim jim deleted the ig-162932482-convert-tests-to-use-testyear branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.