Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gofmt #2257

Merged
merged 1 commit into from Jun 12, 2019

Conversation

2 participants
@pjdufour-truss
Copy link
Contributor

commented Jun 10, 2019

Description

Adds make gofmt. Sometimes you just want to quickly format your new code and pre-commit adds a delay.

Reviewer Notes

Is there anything you would like reviewers to give additional scrutiny?

Setup

None

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • The requirements listed in
    Querying the Database Safely
    have been satisfied.
  • Any new migrations/schema changes:
    • Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
    • Have been communicated to #dp3-engineering
    • Secure migrations have been tested using scripts/run-prod-migrations
  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • User facing changes have been reviewed by design.
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

None

Screenshots

None

Makefile Outdated
@@ -847,6 +847,10 @@ make_test: ## Test make targets not checked by CircleCI
adr_update: .client_deps.stamp ## Update ADR Log
yarn run adr-log

.PHONY: fmt
fmt: ## Run go fmt over all Go files
go fmt $$(go list ./...)

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Jun 10, 2019

Contributor

I had added make pretty a while ago. Maybe remove gofmt from the pretty target and then make it a dependency:

pretty: fmt
  npx ...

Also, maybe instead of fmt we call it gofmt?

@chrisgilmerproj
Copy link
Contributor

left a comment

I left a comment, let me know what you think.

Makefile Outdated
@@ -847,14 +847,17 @@ make_test: ## Test make targets not checked by CircleCI
adr_update: .client_deps.stamp ## Update ADR Log
yarn run adr-log

.PHONY: fmt

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Jun 11, 2019

Contributor

You'll have to update this to .PHONY: gofmt

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀

@pjdufour-truss pjdufour-truss changed the title make fmt make gofmt Jun 12, 2019

@pjdufour-truss pjdufour-truss merged commit 1ae395d into master Jun 12, 2019

17 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details

@pjdufour-truss pjdufour-truss deleted the make_fmt branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.