Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove verbose flag from golangci-lint for cleaner output #2336

Merged
merged 1 commit into from Jul 2, 2019

Conversation

2 participants
@rdhariwal
Copy link
Contributor

commented Jul 1, 2019

Description

We enabled verbose mode while trying to troubleshoot build problems in CircleCI. Now that we have resolved those issues the verboseness of golangci-lint linter can be safely removed.

Reviewer Notes

Golangci-lint should run successfully and its output will be curtailed thanks to verboseness flag in both local and CI environments.

References

Screenshots

image

@rdhariwal rdhariwal requested review from Igarfinkle and kimallen Jul 1, 2019

@rdhariwal

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

I am still trying to figure out how to change concurrency values when golangci-lint runs locally so we can have faster runs on dev machines

@rdhariwal rdhariwal force-pushed the golang-linter-verbose-#166769107 branch from a1ccfb1 to 29cdccf Jul 2, 2019

@rdhariwal rdhariwal merged commit ce0b79a into master Jul 2, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1d025b6...29cdccf
Details
codecov/project/go 59.57% remains the same compared to 1d025b6
Details

@rdhariwal rdhariwal deleted the golang-linter-verbose-#166769107 branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.