Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e test to not choose weekend #2338

Merged
merged 1 commit into from Jul 1, 2019

Conversation

4 participants
@mkrump
Copy link
Contributor

commented Jul 1, 2019

Description

Cypress is choosing a weekend day (non-valid move date), which is causing the e2e test to fail. Update the test date to be a non-weekend date. This is just a temporary fix, but hopefully will resolve fails related to new month.

Setup

make e2e_test

@mkrump mkrump requested review from chrisgilmerproj and donaldthai Jul 1, 2019

@sarboc

sarboc approved these changes Jul 1, 2019

Copy link
Contributor

left a comment

Thanks! Can you add a story somewhere, anywhere, and ping product so they can help us prioritize it?

@donaldthai
Copy link
Contributor

left a comment

🚢 what @sarboc said.

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀

@mkrump mkrump merged commit a598d62 into master Jul 1, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 90b1788...3f54bb9
Details
codecov/project/go 59.6% remains the same compared to 90b1788
Details

@mkrump mkrump deleted the mk-fix-e2e-weekend-issue branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.