Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix invalid date selection issue for e2e_tests #2341
The cypress test is selecting a day from the date picker for the current month. This will fail when the date is a weekend or holiday. Assuming that it's not possible to hard code the date and enter the date and that have to interact via the date picker (as I think that would probably be the easiest way to resolve)?
Wasn't sure the best way to resolve this. Also, not really sure what's been tried here, so if you all could weigh in that would be appreciated. Two commits with two different approaches:
*** Updated ***
Code Review Verification Steps
@@ Coverage Diff @@ ## master #2341 +/- ## ========================================== + Coverage 59.71% 59.73% +0.03% ========================================== Files 261 262 +1 Lines 14702 14732 +30 ========================================== + Hits 8778 8800 +22 - Misses 4902 4909 +7 - Partials 1022 1023 +1
If we already have a way to calculate holidays, I'd use that... As Matt said, prevents us from having to maintain another holiday calendar.
I'm of two minds about this:
For this story, I prefer the