Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric Comparison filters #2345

Merged
merged 1 commit into from Jul 3, 2019

Conversation

2 participants
@pjdufour-truss
Copy link
Contributor

commented Jul 3, 2019

Description

Adds support for numeric comparison filters to ecs-service-logs, e.g.,

ecs-service-logs show -s app -e staging url=* url!=/health* "headers>12" | jq .

Reviewer Notes

Is there anything you would like reviewers to give additional scrutiny?

Setup

make build_tools

Code Review Verification Steps

  • Code follows the guidelines for Logging
  • The requirements listed in
    Querying the Database Safely
    have been satisfied.
  • Any new migrations/schema changes:
    • Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
    • Have been communicated to #dp3-engineering
    • Secure migrations have been tested using scripts/run-prod-migrations
  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • User facing changes have been reviewed by design.
  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

None

Screenshots

N.A.

@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #2345 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
- Coverage   59.88%   59.73%   -0.14%     
==========================================
  Files         261      262       +1     
  Lines       14697    14732      +35     
==========================================
  Hits         8800     8800              
- Misses       4874     4909      +35     
  Partials     1023     1023
@chrisgilmerproj
Copy link
Contributor

left a comment

Nice! I really like this change. Should we consider dropping the old bash scripts?

@pjdufour-truss

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Yeah, in a new PR, but will need to make changes in a few places to properly do that.

@pjdufour-truss pjdufour-truss merged commit 887f925 into master Jul 3, 2019

18 of 19 checks passed

codecov/project/go 59.57% (-0.14%) compared to 6c2e6cc
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6c2e6cc...9a7f953
Details

@pjdufour-truss pjdufour-truss deleted the comparisonFilters branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.