Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming references from prod migrations to deployed migrations #2351

Merged
merged 1 commit into from Jul 5, 2019

Conversation

2 participants
@reggieriser
Copy link
Contributor

commented Jul 5, 2019

Description

I was doing some migrations work and noticed that the psql-prod-migrations script wasn't working as expected. It looks like we still have some scripts/references to "prod" migrations even though the new "deployed" migrations terminology landed recently in #2312. This PR fixes those references and renames the psql-prod-migrations script to psql-deployed-migrations.

Reviewer Notes

I tried to find all the remaining references that needed to be changed, but you may want to double-check that I didn't miss one (or changed one that shouldn't actually change).

Setup

  1. make run_prod_migrations to create a deployed_migrations database
  2. psql-deployed-migrations to start psql for that database

Code Review Verification Steps

  • Request review from a member of a different team.
@codecov

This comment has been minimized.

Copy link

commented Jul 5, 2019

Codecov Report

Merging #2351 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2351      +/-   ##
=========================================
+ Coverage   59.75%   59.8%   +0.05%     
=========================================
  Files         261     261              
  Lines       14691   14716      +25     
=========================================
+ Hits         8778    8800      +22     
- Misses       4892    4893       +1     
- Partials     1021    1023       +2
@chrisgilmerproj
Copy link
Contributor

left a comment

🚀 - thanks for catching these!

@reggieriser reggieriser merged commit 24c42aa into master Jul 5, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 3be2112...36a506e
Details
codecov/project/go 59.64% (+0.05%) compared to 3be2112
Details

@reggieriser reggieriser deleted the rr-fix-prod-migrations-refs branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.