Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds FEATURE_FLAG_ACCESS_CODE to .envrc file. #2367

Merged
merged 1 commit into from Jul 11, 2019

Conversation

3 participants
@chrisrcoles
Copy link
Contributor

commented Jul 9, 2019

Description

Adds FEATURE_FLAG_ACCESS_CODE to .envrc file based on conversation

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀

@tinyels

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Let's try to get this merged asap

@codecov

This comment has been minimized.

Copy link

commented Jul 11, 2019

Codecov Report

Merging #2367 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2367      +/-   ##
==========================================
+ Coverage   59.83%   59.83%   +<.01%     
==========================================
  Files         266      264       -2     
  Lines       14828    14792      -36     
==========================================
- Hits         8871     8850      -21     
+ Misses       4927     4914      -13     
+ Partials     1030     1028       -2

@chrisrcoles chrisrcoles merged commit 005d426 into master Jul 11, 2019

19 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 76bdeb2...8932547
Details
codecov/project/go 59.67% (+<.01%) compared to 76bdeb2
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.