Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "local" as an option before migrations are uploaded to S3 #2373

Merged
merged 4 commits into from Jul 11, 2019

Conversation

3 participants
@garrettqmartin8
Copy link
Contributor

commented Jul 10, 2019

Slack thread for context. TLDR; there is a bug in the run-deployed-migrations script that only allows for migrations that are already in S3, effectively blocking you from uploading your migration to S3.

@chrisgilmerproj
Copy link
Contributor

left a comment

A few fixes and then I'll approve. Thanks for doing this.

@codecov

This comment has been minimized.

Copy link

commented Jul 10, 2019

Codecov Report

Merging #2373 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2373      +/-   ##
=========================================
- Coverage   59.85%   59.8%   -0.05%     
=========================================
  Files         266     266              
  Lines       14768   14857      +89     
=========================================
+ Hits         8838    8884      +46     
- Misses       4902    4942      +40     
- Partials     1028    1031       +3
Update scripts/run-deployed-migrations
Co-Authored-By: Chris Gilmer <chris@truss.works>
@garrettqmartin8

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@chrisgilmerproj changes made

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀 - You're the best!

@garrettqmartin8 garrettqmartin8 force-pushed the gm-fix-upload-secure-migration branch from 3f35485 to 37a4270 Jul 10, 2019

@garrettqmartin8 garrettqmartin8 merged commit 4d568c1 into master Jul 11, 2019

18 of 19 checks passed

codecov/project/go 59.64% (-0.05%) compared to 035838c
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_api Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 035838c...37a4270
Details

@garrettqmartin8 garrettqmartin8 deleted the gm-fix-upload-secure-migration branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.