Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Use new admin users table to authentication and authorization. #2377
We currently can't log into the admin app on dev, experimental, or staging. We're also not properly authorizing users for hitting admin app endpoints. The changes in this PR take advantage of the new
Code Review Verification Steps
requested review from
Jul 11, 2019
This looks really good. I've got some concerns about the migrations that I expect won't be hard to address. The middleware is an interesting approach which I think works because its limited to just the admin app. I'm curious how that might play out for other routes.
@@ Coverage Diff @@ ## master #2377 +/- ## ======================================== - Coverage 59.6% 59.5% -<.1% ======================================== Files 268 267 -1 Lines 15141 15238 +97 ======================================== + Hits 9012 9055 +43 - Misses 5066 5118 +52 - Partials 1063 1065 +2
I'm looking at the secure migrations and a couple things come to mind.
I think we're almost there and I'll keep an eye out for changes so I can approve quickly.
@chrisgilmerproj I've addressed 1 & 3 and in an updated secure migration.
Regarding number 2: I've replaced as many references to superuser as I've found and have been rebasing master frequently to make sure I'm not letting any slip through the cracks. Are there other cases that I'm not thinking of?