Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add command line flags to turn on routes #2442
Creates command line flags so that we can separate services like Orders out from the rest of the app when running containers.
You'll want to make sure your dev environment kicks up
You can also change your envrc file to make it think its staging to see if the flag check function for services.go is working properly. This will also require temporarily setting auth local to false and setting the mutual tls flag to true.
Code Review Verification Steps
@@ Coverage Diff @@ ## master #2442 +/- ## ======================================== - Coverage 60.1% 59.5% -0.5% ======================================== Files 284 275 -9 Lines 15890 15563 -327 ======================================== - Hits 9535 9252 -283 + Misses 5235 5230 -5 + Partials 1120 1081 -39
@Ryan-Koch - I was thinking last night that when you deploy to experimental we need to verify that the Orders stuff still works on
@jamesatheyDDS - the big impact for Orders here is that we won't be running any of the rest of the app on the same container. Only the orders API will be available. I'm pretty sure you don't need DPS for Orders but you should tell us. The larger picture is that we're keeping Login.gov auth on the
I hear you on this. Consistency would be ideal here. I'll go about seeing if I can safely rename the things on this end to match the public wording we use in the api structure itself. It seems a lighter lift than making that structure conform to this naming convention. I'll follow back up once that commit is pushed up.