Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update error msgs #2476

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@lynzt
Copy link
Contributor

commented Aug 1, 2019

Update error msgs to use tsp instead of office && admin instead of office

Came across this when doing a separate code review...

@lynzt lynzt requested review from garrettqmartin8 and chrisgilmerproj Aug 1, 2019

@lynzt lynzt added the ttv label Aug 1, 2019

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀

@codecov

This comment has been minimized.

Copy link

commented Aug 1, 2019

Codecov Report

Merging #2476 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2476     +/-   ##
========================================
+ Coverage    59.7%   59.7%   +0.1%     
========================================
  Files         274     273      -1     
  Lines       15554   15521     -33     
========================================
- Hits         9271    9257     -14     
+ Misses       5203    5184     -19     
  Partials     1080    1080
Impacted Files Coverage Δ
pkg/handlers/adminapi/office_users.go 94.5% <0%> (-1.1%) ⬇️
pkg/handlers/adminapi/api.go 0% <0%> (ø) ⬆️
pkg/services/accesscode/fetch_access_code.go 100% <0%> (ø) ⬆️
pkg/dates/move_dates.go

@lynzt lynzt merged commit 283e8ae into master Aug 1, 2019

16 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing 0606f2b...1cec3dc
Details
codecov/project/go 59.5% (+0.1%) compared to 0606f2b
Details

@lynzt lynzt deleted the lt-tsp-test-wording branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.