Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin orders index endpoint #2510

Open
wants to merge 1 commit into
base: master
from

Conversation

@garrettqmartin8
Copy link
Contributor

commented Aug 12, 2019

Description

Infra needs a way to confirm which branch of service the incoming orders are from and how many have come in. This PR adds an endpoint to the admin API that returns all orders in the system (without PII).

Setup

  1. make server_run
  2. make client_run
  3. Log into the admin app
  4. Visit adminlocal:3000/admin/v1/orders

Code Review Verification Steps

  • Request review from a member of a different team.
@codecov

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codecov Report

Merging #2510 into master will decrease coverage by 0.1%.
The diff coverage is 20.7%.

@@           Coverage Diff            @@
##           master   #2510     +/-   ##
========================================
- Coverage    59.7%   59.6%   -<.1%     
========================================
  Files         284     281      -3     
  Lines       15885   15744    -141     
========================================
- Hits         9475    9378     -97     
+ Misses       5293    5267     -26     
+ Partials     1117    1099     -18
Impacted Files Coverage Δ
pkg/handlers/adminapi/orders.go 0% <0%> (ø)
pkg/handlers/adminapi/api.go 0% <0%> (ø) ⬆️
pkg/services/order/order_list_fetcher.go 100% <100%> (ø)
pkg/handlers/internalapi/move_documents.go 58.9% <0%> (-11.2%) ⬇️
pkg/models/moving_expense_document.go 69% <0%> (-4.2%) ⬇️
pkg/handlers/internalapi/api.go 0% <0%> (ø) ⬆️
...g/services/move_documents/weight_ticket_updater.go
pkg/services/move_documents/ppm_completer.go
...kg/services/move_documents/update_move_document.go
...services/move_documents/storage_expense_updater.go
... and 4 more
@chrisgilmerproj
Copy link
Contributor

left a comment

I'll review this as quickly as possible. I want to validate the auth stuff here.

@chrisgilmerproj chrisgilmerproj requested a review from jamesatheyDDS Aug 12, 2019

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@jamesatheyDDS - this is how we are considering looking at Orders info in the Admin. I'd like you to be able to test that this works and also doesn't invalidate our security precautions around Orders read/write permissions. Can you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.