Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws-vault double wrapping from Makefile. #2514

Merged

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Aug 12, 2019

Description

What's happening here is that the aws-vault exec transcom-ppp -- was logging into the server on our behalf except for the aws-vault bits. So the server would choke expecting a aws-vault profile name.

Try this with:

STORAGE_BACKEND=s3 make server_run_standalone

@chrisgilmerproj chrisgilmerproj requested review from mr337, mkrump and rdhariwal Aug 12, 2019

@chrisgilmerproj chrisgilmerproj self-assigned this Aug 12, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codecov Report

Merging #2514 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2514     +/-   ##
========================================
- Coverage    59.7%   59.7%   -<.1%     
========================================
  Files         283     284      +1     
  Lines       15878   15893     +15     
========================================
  Hits         9476    9476             
- Misses       5285    5300     +15     
  Partials     1117    1117
Impacted Files Coverage Δ
pkg/handlers/converters_strfmt.go 0% <0%> (ø)
@mkrump

mkrump approved these changes Aug 12, 2019

Copy link
Contributor

left a comment

solved!

@chrisgilmerproj chrisgilmerproj merged commit 2a3c52d into master Aug 12, 2019

16 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing 78b74fc...e7d531f
Details
codecov/project/go 59.5% (-<.1%) compared to 78b74fc
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_fix_serve_standalone_aws_vault_double_wrap branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.