Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing semicolons to sql #2519

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Aug 13, 2019

Description

I'm pulling this out of #2349 so that it can go in with #2506. Fixing SQL migration files is important so that they run correctly locally.

@chrisgilmerproj chrisgilmerproj self-assigned this Aug 13, 2019

@chrisgilmerproj chrisgilmerproj referenced this pull request Aug 13, 2019

Merged

Upgrade fizz files to the latest spec #2506

0 of 2 tasks complete
@lynzt

lynzt approved these changes Aug 13, 2019

Copy link
Contributor

left a comment

🚢

@codecov

This comment has been minimized.

Copy link

commented Aug 13, 2019

Codecov Report

Merging #2519 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2519     +/-   ##
========================================
- Coverage    59.7%   59.7%   -<.1%     
========================================
  Files         283     284      +1     
  Lines       15873   15888     +15     
========================================
  Hits         9473    9473             
- Misses       5284    5299     +15     
  Partials     1116    1116
Impacted Files Coverage Δ
pkg/dates/move_dates.go 0% <0%> (ø)

@chrisgilmerproj chrisgilmerproj merged commit 4bc9bfb into master Aug 13, 2019

16 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing 902c8a6...dec7044
Details
codecov/project/go 59.5% (-<.1%) compared to 902c8a6
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_add_missing_semi_to_sql branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.