Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same env var as aws-vault code for role TTL #2520

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Aug 13, 2019

Description

The aws-vault code uses a different env var for TTL than we used. Lining up the variables to be the same will help guarantee better behavior when using aws-vault inside or out of our code.

https://github.com/99designs/aws-vault/blob/master/cli/exec.go#L60-L63

@chrisgilmerproj chrisgilmerproj requested review from mr337 and rdhariwal Aug 13, 2019

@chrisgilmerproj chrisgilmerproj self-assigned this Aug 13, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 13, 2019

Codecov Report

Merging #2520 into master will decrease coverage by 0.1%.
The diff coverage is 25%.

@@           Coverage Diff            @@
##           master   #2520     +/-   ##
========================================
- Coverage    59.7%   59.7%   -<.1%     
========================================
  Files         283     284      +1     
  Lines       15873   15888     +15     
========================================
  Hits         9473    9473             
- Misses       5284    5299     +15     
  Partials     1116    1116
Impacted Files Coverage Δ
pkg/cli/vault.go 16.5% <25%> (ø) ⬆️
pkg/dates/move_dates.go 0% <0%> (ø)
@mr337

mr337 approved these changes Aug 13, 2019

Copy link
Contributor

left a comment

LGTM!

@chrisgilmerproj chrisgilmerproj merged commit 82b4bba into master Aug 13, 2019

15 of 16 checks passed

codecov/patch/go 25% of diff hit (target 59.6%)
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/project/go 59.5% (-<.1%) compared to 902c8a6
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_update_vault_aws_assume_role_ttl branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.