Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit condition to prevent curl from breaking the build #2527

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@garrettqmartin8
Copy link
Contributor

commented Aug 13, 2019

Description

Codecov breaks our build during the server_test_coverage build step the curl request times out. This PR adds an exit condition to break out of that step if we hit the retry limit.

References

@@ -451,7 +451,7 @@ jobs:
- run:
name: upload code coverage to codecov
command: |
curl -L --retry 5 --retry-connrefused https://codecov.io/bash --output /home/circleci/codecov
curl -L --retry 5 --retry-connrefused https://codecov.io/bash --output /home/circleci/codecov || exit 0

This comment has been minimized.

Copy link
@garrettqmartin8

garrettqmartin8 Aug 13, 2019

Author Contributor

@chrisgilmerproj I know you suggested using || true, but that would allow the build step to continue. I think we just want to short circuit using the exit condition. Thoughts?

@chrisgilmerproj
Copy link
Contributor

left a comment

🚀 - Works for me

@garrettqmartin8 garrettqmartin8 merged commit ea7dc06 into master Aug 14, 2019

14 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details

@garrettqmartin8 garrettqmartin8 deleted the gm-codecov branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.