Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB_REGION env var for environmental tests #2653

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@Ronolibert
Copy link
Contributor

commented Sep 5, 2019

Description

Added back missing DB_REGION environmental variable which is used in environmental acceptance tests

@Ronolibert Ronolibert added the 🦇team label Sep 5, 2019

@Ronolibert Ronolibert requested review from chrisgilmerproj and LeDeep Sep 5, 2019

@chrisgilmerproj
Copy link
Contributor

left a comment

👍 - Thanks for this!

@codecov

This comment has been minimized.

Copy link

commented Sep 5, 2019

Codecov Report

Merging #2653 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2653     +/-   ##
========================================
+ Coverage    56.1%   56.1%   +0.1%     
========================================
  Files         270     270             
  Lines       12327   12285     -42     
========================================
- Hits         6905    6882     -23     
+ Misses       4731    4719     -12     
+ Partials      691     684      -7
Impacted Files Coverage Δ
pkg/services/accesscode/validate_access_code.go
pkg/notifications/move_submitted.go
pkg/services/accesscode/fetch_access_code.go 100% <0%> (ø)
pkg/services/accesscode/claim_access_code.go 100% <0%> (ø)

@Ronolibert Ronolibert merged commit dd5d25f into master Sep 5, 2019

16 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing a6a8a8e...72d4ec3
Details
codecov/project/go 55.8% (+0.1%) compared to a6a8a8e
Details

@Ronolibert Ronolibert deleted the roc-add-env-var-experimental branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.