Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Identity Web Services and DoD-signed x509 certs #2659

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@jamesatheyDDS
Copy link
Contributor

commented Sep 6, 2019

Just adding some Markdown documentation to help developers understand MilMove's usage of two things:

  1. DMDC's Identity Web Services
  2. DoD-signed (as opposed to commercially-signed) server certificates

@jamesatheyDDS jamesatheyDDS changed the title Add documentation for Identity Add documentation for Identity Web Services and DoD-signed x509 certs Sep 6, 2019

@jamesatheyDDS

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

If you want me to link to these new .md files from another .md file, just let me know.

Also, I am not dogmatic about their location. Is there a better folder for them?

@jamesatheyDDS jamesatheyDDS self-assigned this Sep 6, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 6, 2019

Codecov Report

Merging #2659 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2659     +/-   ##
========================================
- Coverage    56.3%   55.4%   -0.9%     
========================================
  Files         271     269      -2     
  Lines       12393   12423     +30     
========================================
- Hits         6971    6872     -99     
- Misses       4725    4851    +126     
- Partials      697     700      +3
Impacted Files Coverage Δ
pkg/models/queue.go 40.2% <0%> (-59.8%) ⬇️
pkg/handlers/internalapi/move_queue_items.go 77.4% <0%> (ø) ⬇️
pkg/notifications/notification_stub.go 0% <0%> (ø) ⬆️
pkg/notifications/notification_sender.go 0% <0%> (ø) ⬆️
pkg/services/move_documents/ppm_completer.go 60% <0%> (ø) ⬆️
pkg/services/accesscode/fetch_access_code.go
pkg/dates/calculators.go
pkg/notifications/move_reviewed.go
pkg/notifications/move_canceled.go 0% <0%> (ø)
pkg/models/shipment_summary_worksheet.go 89.5% <0%> (+0.1%) ⬆️
... and 3 more
@chrisgilmerproj
Copy link
Contributor

left a comment

This looks great, thank you!

@jamesatheyDDS jamesatheyDDS merged commit c2c5de2 into master Sep 9, 2019

16 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing 8cd66b0...176680b
Details
codecov/project/go 55.1% (-0.9%) compared to 8cd66b0
Details

@jamesatheyDDS jamesatheyDDS deleted the electronic-orders-docs branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.