Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the ECS tasks that are RUNNING and PENDING during a deploy #2667

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Sep 9, 2019

Description

When a deploy fails we want to know the ECS Task ID so we can go to cloudwatch and look at the logs and find out what happened.

@chrisgilmerproj chrisgilmerproj requested review from mr337, mkrump and rdhariwal Sep 9, 2019

@chrisgilmerproj chrisgilmerproj self-assigned this Sep 9, 2019

@codecov

This comment has been minimized.

Copy link

commented Sep 9, 2019

Codecov Report

Merging #2667 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2667     +/-   ##
========================================
+ Coverage    56.1%   56.1%   +0.1%     
========================================
  Files         273     273             
  Lines       12463   12464      +1     
========================================
+ Hits         6991    6992      +1     
  Misses       4772    4772             
  Partials      700     700
Impacted Files Coverage Δ
pkg/services/accesscode/claim_access_code.go 100% <0%> (ø) ⬆️
pkg/services/accesscode/validate_access_code.go
pkg/services/accesscode/fetch_access_code.go 100% <0%> (ø)
@mr337
mr337 approved these changes Sep 9, 2019
Copy link
Contributor

left a comment

These are just listing commands that run with no problems. 🚢

@chrisgilmerproj chrisgilmerproj merged commit 1e5037f into master Sep 9, 2019

16 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing c2c5de2...c459698
Details
codecov/project/go 55.9% (+0.1%) compared to c2c5de2
Details

@chrisgilmerproj chrisgilmerproj deleted the cg_display_ecs_tasks_on_deploy branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.