Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a diagnostic target for the project. #2751

Merged
merged 2 commits into from Oct 4, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Oct 1, 2019

Description

Lots of folks are wondering if their setup is correct and we don't have one explicit target to just check. This adds that target and does some additional stuff.

Additionally:

  • Add a script to check node version.
  • Add a script to check available space left in docker
  • Update script messages

See https://docs.docker.com/docker-for-mac/faqs/#dockerraw-consumes-an-insane-amount-of-disk-space

Setup

make diagnostic
…version. Update script messages
@chrisgilmerproj chrisgilmerproj self-assigned this Oct 1, 2019
@chrisgilmerproj chrisgilmerproj marked this pull request as ready for review Oct 3, 2019
@mr337

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

Is some of this intended to be duplicated from https://github.com/transcom/ppp-infra/blob/master/Makefile#L52?

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Is some of this intended to be duplicated from https://github.com/transcom/ppp-infra/blob/master/Makefile#L52?

Yeah, its largely duplicated on purpose. I didn't want to mess with the other one and I wanted a diagnostic with no side effects - so nothing changes on running it.

Copy link
Contributor

left a comment

i'm seeing:

WARNING: pkcs11-tool not found, install via: brew install opensc; chmod go+w /usr/local/bin/pkcs11-tool; brew link opensc
WARNING: pkcs15-tool not found, install via: brew install opensc; chmod go+w /usr/local/bin/pkcs15-tool; brew link opensc

do we need those?

else, it lists things I have installed...
I'm going to defer to someone more familiar w/ scripting for approval, but LGTM...

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

do we need those?

Yeah, if you want to work with the Orders API and do CAC stuff.

else, it lists things I have installed...
I'm going to defer to someone more familiar w/ scripting for approval, but LGTM...

Yeah. It should just list stuff is ok. After prereqs it will check all your versions. Finally it checks your docker space available.

@mr337
mr337 approved these changes Oct 4, 2019
Copy link
Contributor

left a comment

Overall I think this is good and pretty straight forward. With 👍 from Lindsay and I lets 🚢

@chrisgilmerproj chrisgilmerproj merged commit 386d029 into master Oct 4, 2019
17 checks passed
17 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing 7e8d01e...6619710
Details
codecov/project/go 57.6% remains the same compared to 7e8d01e
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_diagnostic branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.