Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated mocks #2766

Closed
wants to merge 1 commit into from

Conversation

@reggieriser
Copy link
Contributor

commented Oct 3, 2019

Description

When running make clean mocks_generate, I noticed that our generated Go files for mocks were showing up as local diffs. It looks like the local changes use factored imports but what's in source control uses individual imports. Verified with @chrisgilmerproj that he was seeing the same thing. This PR updates those mocks so we no longer see the diffs.

Reviewer Notes

@chrisgilmerproj is looking into why this wasn't caught by our generated code checks in CircleCI and will be handling that in a separate PR.

Setup

make clean mocks_generate, then do a git status to verify that there are no local diffs.

Code Review Verification Steps

  • Request review from a member of a different team.
@reggieriser reggieriser requested review from chrisgilmerproj, gidjin and lynzt Oct 3, 2019
Copy link
Contributor

left a comment

🚀 - Thanks!

@gidjin
gidjin approved these changes Oct 3, 2019
Copy link
Contributor

left a comment

Generated code is no longer left modified after running the generate command as described. 🚢

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

These change were cherry-picked into another branch and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.