Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check-generated-code to recognize changes to mocks #2767

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Oct 3, 2019

Description

As noticed in #2766, check-generated-code wasn't properly checking the mocks/ dirs because go list ./... gives the fully qualified package name and not the directory name.

@chrisgilmerproj chrisgilmerproj self-assigned this Oct 3, 2019
@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

@gidjin
gidjin approved these changes Oct 3, 2019
Copy link
Contributor

left a comment

Change looks good and catches modified code described in #2766

@chrisgilmerproj chrisgilmerproj merged commit 1b55fe4 into master Oct 3, 2019
17 checks passed
17 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing 93930bc...d62e691
Details
codecov/project/go 57.3% remains the same compared to 93930bc
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_fix_check_generated_code branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.