Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB docs for IAM authentication and revert #2768

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@mr337
Copy link
Contributor

commented Oct 3, 2019

Description

This PR expands on the DB docs to provide information on RDS IAM and how to revert back to using DB username and pass.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@mr337 mr337 force-pushed the lh-rds-iam-doc branch from 91516dd to 5b0f3d4 Oct 3, 2019
@mr337 mr337 requested review from chrisgilmerproj and rdhariwal Oct 3, 2019
DB_IAM_ROLE=YOUR_CONTAINER_ROLE_ARN_HERE
```

### Reverting Task to use password authentication

This comment has been minimized.

Copy link
@mr337

mr337 Oct 3, 2019

Author Contributor

I would like to get a good set of 👀 on this as I don't want to experiment with environments on this. The only part I partially question is how chamber injects the db_password from the Param store.

@mr337 mr337 force-pushed the lh-rds-iam-doc branch from 5b0f3d4 to f4b3d2f Oct 3, 2019
docs/database.md Outdated Show resolved Hide resolved
docs/database.md Outdated Show resolved Hide resolved
docs/database.md Outdated Show resolved Hide resolved
docs/database.md Outdated Show resolved Hide resolved
docs/database.md Outdated Show resolved Hide resolved
docs/database.md Outdated Show resolved Hide resolved
@mr337 mr337 requested a review from chrisgilmerproj Oct 7, 2019
Copy link
Contributor

left a comment

🚀 !

@mr337

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

Hmm, build_storybook_app has this PR hung up

@mr337 mr337 force-pushed the lh-rds-iam-doc branch from b9c7bfc to a7757a0 Oct 7, 2019
@mr337

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

Rebased this wondering if there is some recent storybook stuff in master I am possibly missing.

@mr337 mr337 merged commit 54c51c9 into master Oct 7, 2019
18 checks passed
18 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing b08f6b6...a7757a0
Details
codecov/project/go 57.6% remains the same compared to b08f6b6
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.