Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build any deps when running server tests, assume that deps are already built #2773

Merged
merged 7 commits into from Oct 3, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Oct 3, 2019

Description

For server tests there is no reason to build all of server_deps since most of that stuff is not actively used. Plus the code is checked in so maybe server_deps shouldn't be building swagger and mockery anyway. In any case this removes that bit from CircleCI.

I cherry-picked #2766 into this one.

@gidjin
gidjin approved these changes Oct 3, 2019
Copy link
Contributor

left a comment

🚀

Copy link
Contributor

left a comment

LGTM!

@chrisgilmerproj chrisgilmerproj merged commit 93930bc into master Oct 3, 2019
17 checks passed
17 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing f5a9dc2...7c976c7
Details
codecov/project/go 57.3% remains the same compared to f5a9dc2
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_server_test_circleci branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.