Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Tear down each cloned DB instance at the end of each test suite run #2774
I'm positing that the reason we're having problems in CircleCI with our golang unit tests right now is due to a strange combination of things:
This PR tries to solve all of these.
If you log into the postgres instance to look at the DB's you'll see something like this now:
@@ Coverage Diff @@ ## master #2774 +/- ## ======================================== + Coverage 57.8% 57.8% +0.1% ======================================== Files 280 278 -2 Lines 12635 12623 -12 ======================================== - Hits 7296 7293 -3 + Misses 4591 4582 -9 Partials 748 748
lynzt left a comment
looks good and thanks for cleaning up the
question: when looking at the db, are we creating a separate db per test?
I hope it does!
Yes, its been doing that for months now. And its per-testsuite and named after the package.
Yep, that's what you ought to see. But hopefully the test suite