Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ttv 168758755 fix storybook build #2775

Merged
merged 7 commits into from Oct 4, 2019

Conversation

@donaldthai
Copy link
Contributor

commented Oct 4, 2019

Description

Fixes the storybook build and adds a new step in CircleCi to make sure the storybook build passes.

Reviewer Notes

  • I renamed the Makefile cmd build_storybook to storybook_build to stay consistent with our pattern

Setup

make client_build
make storybook_build

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Copy link
Contributor

left a comment

👏 👏 👏

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

left a comment

You need to fix two things in your config but this is ready to go. After you merge it we can update the required steps in Github for branches to pass and then it will block other folks that break storybook.

@donaldthai donaldthai merged commit aa1ce71 into master Oct 4, 2019
18 checks passed
18 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing 1b55fe4...c43b588
Details
codecov/project/go 57.3% remains the same compared to 1b55fe4
Details
@donaldthai donaldthai deleted the ttv_168758755_fix_storybook_build branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.