Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated chamber to point to advertised v2 go module name #2777

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@reggieriser
Copy link
Contributor

commented Oct 7, 2019

Description

I noticed that the go dependency updater failed this morning:
go.mod has post-v0 module path "github.com/segmentio/chamber/v2" at revision 042d840206ee

It looks like chamber has recently switched their advertised name:
v2.7.2 is a code-only change that switches our advertised go module name to github.com/segmentio/chamber/v2, which it should have been all along.

This PR updates our references to point to v2 -- which also causes us to get on a tagged version of chamber. We were previously on v2.x code, but about a month behind.

Reviewer Notes

Is there anything chamber-related that I've missed or failed to consider?

Setup

make clean
make server_build --> should be no diffs
make bin/chamber --> should be no diffs, chamber in ./bin/chamber
make server_build_linux --> should be no diffs, a linux version in ./bin_linux/chamber
go mod tidy --> should be no diffs

Code Review Verification Steps

  • Request review from a member of a different team.
@reggieriser

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

Changing this to a WIP while I hunt down why it's failing server tests.

@reggieriser reggieriser added the wip label Oct 7, 2019
@lynzt
lynzt approved these changes Oct 7, 2019
Copy link
Contributor

left a comment

Good find...
LGTM and I see no diffs when running the cmds above. 🚢

@reggieriser

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

Server tests seemed to be running fine locally, so this may be failing due to the other server test flakiness we've had lately. Will try again once #2774 lands to see if that helps.

Copy link
Contributor

left a comment

🚀 - My PR #2774 will be in shortly and I bet if you merge that in you'll be set.

@reggieriser reggieriser removed the wip label Oct 7, 2019
@reggieriser reggieriser merged commit d0a26fd into master Oct 7, 2019
18 checks passed
18 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing 6ef6ec7...2f0893f
Details
codecov/project/go 57.6% remains the same compared to 6ef6ec7
Details
@reggieriser reggieriser deleted the rr-update-chamber branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.