Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add a docker-compose to run server_test in circleci locally #2782
Trying to see if we can run server_test in a circleCI container locally
docker-compose -f docker-compose.circle.yml --compatibility up server_test
NOTE You'll want to run
Code Review Verification Steps
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this!
Please frame screenshots to show enough useful context but also highlight the affected regions.
I saw some stuff that right off the bat we should update. But I think this is a great start for speeding up the cycle of review.
The thing we really need to look into is modifying the docker-compose containers to have the same resource footprint as CircleCI so we can catch stuff. I believe there are
@@ Coverage Diff @@ ## master #2782 +/- ## ====================================== Coverage 58.2% 58.2% ====================================== Files 291 291 Lines 12755 12755 ====================================== Hits 7412 7412 Misses 4593 4593 Partials 750 750
What was missing was a bunch of environment variables. But once I sorted that bit I got things passing locally. Fortunately I also noticed that we could get some test failures of the exact same sort we're seeing in CircleCI with your branch. So we're one track.
Additionally, I found out we aren't doing the right thing with our env vars for these tests anyway so I think I've updated it correctly in CircleCI. I'll keep an eye on it. I may also decrease the resources for this docker-compose file of yours and see what that does.
I checked out the changes look good, though that's a lot of environment variables. I ran the test a couple of times locally and got one passing and one failing run, so I agree we have a way to replicate the issue. I did try the following but still had a pass and a fail so I don't think it's specific to the image.
server_test: - image: trussworks/circleci-docker-primary:e5c10bf19185aa55354901106bad3ffd4c016265 + #image: trussworks/circleci-docker-primary:e5c10bf19185aa55354901106bad3ffd4c016265 + image: golang:1.12
I agree. This is good work!
That's good to know. I'd wait on merging this until the go1.13 PR gets merged in and then let's update the primary image here too.