Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix organization model to reflect nullable columns #2783

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@garrettqmartin8
Copy link
Contributor

commented Oct 8, 2019

@chrisgilmerproj this came from your slack message.

I introduced nullable columns for poc_email and poc_phone in migrations/20190710151514_make_organizations_poc_nullable.up.fizz, but never updated the app code the reflect that.

@garrettqmartin8 garrettqmartin8 requested a review from chrisgilmerproj Oct 8, 2019
Copy link
Contributor

left a comment

I'm surprised we decided to move these to be nullable. I thought there was some decision to ensure that any Organization had a POC, so at least one or the other needed to be filled as well as Name.

I'm approving based on the fact that this fixes the issue but I'm concerned that we've now allowed folks to not enter a critical piece of info. Maybe the validators should be checking that at least one piece of information is available.

@garrettqmartin8

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

@chrisgilmerproj yeah I seem to remember talking about that, but not exactly sure where we landed. I've created a ticket to re-evaluate the decision. Thanks!

@garrettqmartin8 garrettqmartin8 merged commit 6d9f1a3 into master Oct 9, 2019
18 checks passed
18 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/patch/go Coverage not affected when comparing 0ff2e0a...943cc8b
Details
codecov/project/go 57.7% (-<.1%) compared to 0ff2e0a
Details
@garrettqmartin8 garrettqmartin8 deleted the gm-fix-admin-users-org-string-bug branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.