Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to get ALL moves including suppressed: 169015597 #2784

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@lynzt
Copy link
Contributor

commented Oct 8, 2019

Description

We need to see some move data from "hidden" moves to get a user associated w/ a locator id.

Reviewer Notes

This is temporary and will be backed out after we find the user associated w/ the move (hopefully in the next deploy)

Setup

make server_run
make client_run

open network tab and then hit: http://officelocal:3000/queues/MBxFJqtAoWfTYJd
look at the response from MBxFJqtAoWfTYJd which should have ALL moves including those that are suppressed.

Code Review Verification Steps

.

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@lynzt lynzt requested review from Ryan-Koch and chrisgilmerproj Oct 8, 2019
@lynzt lynzt added the ttv label Oct 8, 2019
@lynzt lynzt requested a review from kahlouie Oct 8, 2019
Copy link
Contributor

left a comment

🚀

@lynzt lynzt merged commit 2f6f3c8 into master Oct 8, 2019
17 of 18 checks passed
17 of 18 checks passed
codecov/patch/go 0% of diff hit (target 57.7%)
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
ci/circleci: server_test_coverage Your tests passed on CircleCI!
Details
codecov/project/go 57.5% (-0.1%) compared to 0ff2e0a
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.