Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HHG access codes #2886

Merged
merged 7 commits into from Nov 1, 2019

Conversation

@mkrump
Copy link
Contributor

mkrump commented Oct 30, 2019

Description

  • Since HHG moves are no longer part of the system, this PR removes the HHG specific access codes.
  • Also, this PR adds an additional bit of helper text to the access code view in the admin ui to let users know that they don't need the prefix to search for access codes (now Access Code (don't include prefix))

Reviewer Notes

  • The uswds upgrade changed the font size for the admin interface (a fix is in progress see https://ustcdp3.slack.com/archives/CP497TGAU/p1572466500137600), so can ignore that. But let me know if there is better way to style the input to fit all of the added helper text into it.
  • Deployed to experimental 77c2e5e and confirmed that no HHG access codes were present after the migration was run. Is there anything else that should be verified before removing this data?

Setup

Remove HHG Access Codes

Comment out 20191030192621_remove_hhg_access_codes.up.sql in migrations_manifest.txt so the migration won't initially be applied.

make db_dev_reset && make db_dev_migrate
# generate some access codes
go run cmd/generate_access_codes/main.go cmd/generate_access_codes/logger.go --ppm 1000 --hhg 100

Check the access code counts in the dev db

SELECT move_type, count(*)
FROM access_codes
GROUP BY move_type;

Uncomment 20191030192621_remove_hhg_access_codes.up.sql in migrations_manifest.txt

make db_dev_migrate

And check the access code count again

SELECT move_type, count(*)
FROM access_codes
GROUP BY move_type;

The HHG access codes should no longer be there.

Admin UI helper text

make server_run
make admin_client_run

For the "Access Codes" panel, the search box will now says "Access Code (don't include prefix)"

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@mkrump mkrump added roci wip and removed wip labels Oct 30, 2019
@mkrump mkrump requested review from chrisgilmerproj, donaldthai, jim and lynzt Oct 31, 2019
@mkrump mkrump marked this pull request as ready for review Oct 31, 2019
Copy link
Contributor

donaldthai left a comment

A question but LGTM.

fullWidth
alwaysOn
resettable
/>
<SelectInput source="move_type" choices={[{ id: 'PPM', name: 'PPM' }, { id: 'HHG', name: 'HHG' }]} />

This comment has been minimized.

Copy link
@donaldthai

donaldthai Oct 31, 2019

Contributor

Should we remove the HHG enum here as well? I think there's also an enum value for the AccessCodes definition in the admin.yaml file.

This comment has been minimized.

Copy link
@mkrump

mkrump Nov 1, 2019

Author Contributor

That's a good point. Will remove both of those too 376aebb.

Copy link
Contributor

chrisgilmerproj left a comment

🚀

@mkrump mkrump merged commit ef361ff into master Nov 1, 2019
16 checks passed
16 checks passed
Summary no rules match, no planned actions
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@mkrump mkrump deleted the mk-168762441-remove-hhg-access-codes branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.