Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to bad video link in Service Object design doc #2896

Merged
merged 2 commits into from Nov 1, 2019

Conversation

@jacquelineIO
Copy link
Contributor

jacquelineIO commented Nov 1, 2019

Description

Fix the video linked at the bottom of the page to point to file in USTC instead of the old DDS drive.

Reviewer Notes

n/a

Setup

n/a

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

Screenshots

n/a

Copy link
Contributor

chrisgilmerproj left a comment

🚀

@jacquelineIO jacquelineIO changed the title fix to bad video link fix to bad video link in Service Object design doc Nov 1, 2019
@LeDeep
LeDeep approved these changes Nov 1, 2019
@jacquelineIO jacquelineIO merged commit a3f4937 into master Nov 1, 2019
16 checks passed
16 checks passed
Summary no rules match, no planned actions
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@jacquelineIO jacquelineIO deleted the jm-fix-links-in-serviceobjects-design-doc branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.