Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure dependabot #2897

Merged
merged 4 commits into from Nov 1, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Nov 1, 2019

Description

Initial configuration of dependabot which covers JS, Go, and Docker. Interested in seeing what we can do with this.

@chrisgilmerproj chrisgilmerproj requested review from mr337, mkrump and rdhariwal Nov 1, 2019
@chrisgilmerproj chrisgilmerproj self-assigned this Nov 1, 2019
.dependabot/config.yml Outdated Show resolved Hide resolved
.dependabot/config.yml Outdated Show resolved Hide resolved
@chrisgilmerproj chrisgilmerproj requested a review from tinyels Nov 1, 2019
@mkrump

This comment has been minimized.

Copy link
Contributor

mkrump commented Nov 1, 2019

LTGM. One question though do you think it's worth trying to set the automerge conditions here? https://dependabot.com/docs/config-file/#automerged_updates I suspect branch protection approval condition will still block us, but this seems cleaner and it allows you to say only automerge patches for instance.

@mkrump
mkrump approved these changes Nov 1, 2019
@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

chrisgilmerproj commented Nov 1, 2019

LTGM. One question though do you think it's worth trying to set the automerge conditions here? https://dependabot.com/docs/config-file/#automerged_updates I suspect branch protection approval condition will still block us, but this seems cleaner and it allows you to say only automerge patches for instance.

I was going to try out the automerge in a different PR :) I absolutely think we ought to try out automerge though and possibly remove some of our other tooling if it works.

@chrisgilmerproj chrisgilmerproj merged commit e5631ef into master Nov 1, 2019
16 checks passed
16 checks passed
Summary no rules match, no planned actions
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_configure_dependabot branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.