Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove team leads as reviewers to dependabot PRs #2950

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@mkrump
Copy link
Contributor

mkrump commented Nov 6, 2019

Description

Remove team leads as reviewers on dependabot PRs. This was a carryover from an old process that ran much less frequently and this is leading to a lot of spam for the team leads.

@mkrump mkrump requested review from chrisgilmerproj, sarboc and chrisrcoles Nov 6, 2019
@mkrump mkrump changed the title Remove team leads as reviewers Remove team leads as reviewers to dependabot PRs Nov 6, 2019
@chrisgilmerproj chrisgilmerproj requested review from jacquelineIO and tinyels Nov 6, 2019
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - Thanks!

To be clear, team leads are still going to be responsible for reviewing and merging the PRs from dependabot that are not auto-merged. That includes major version updates. I'll make sure to discuss the changes at the Lead's meeting this week.

@tinyels
tinyels approved these changes Nov 6, 2019
@mkrump mkrump merged commit 7e53140 into master Nov 6, 2019
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@mkrump mkrump deleted the mk-remove-team-leads-as-reviewers branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.