Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external pre-commit-hooks instead of local ones #2960

Merged
merged 6 commits into from Nov 12, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Nov 7, 2019

Description

This follows on from transcom/ppp-infra#723 where I've moved pre-commit hooks to a separate repository so they can be shared.

Try with pre-commit run -a

@chrisgilmerproj chrisgilmerproj force-pushed the cg_use_external_pre_commit_hooks branch from 8cd5fc0 to e35cae0 Nov 7, 2019
@chrisgilmerproj chrisgilmerproj marked this pull request as ready for review Nov 7, 2019
@chrisgilmerproj chrisgilmerproj requested review from mr337 and rdhariwal Nov 7, 2019
@mr337
mr337 approved these changes Nov 7, 2019
Copy link
Contributor

mr337 left a comment

All happy precommit hooks on my end when running. 🚢

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

chrisgilmerproj commented Nov 7, 2019

I made one change to this. Because we no longer carry markdown-spellcheck in the package.json so that its not constantly flagged as a security risk by dependabot it means that make spellcheck stops working. I've added in a check in the Makefile that prompts you to yarn global add markdown-spellcheck. I think this is a satisfactory compromise as this tool isn't often used and it avoids accidentally adding it back to the project.

@sarboc
sarboc approved these changes Nov 12, 2019
@chrisgilmerproj chrisgilmerproj merged commit f2e4fb3 into master Nov 12, 2019
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_use_external_pre_commit_hooks branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.