Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing generated mocks #2971

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@reggieriser
Copy link
Contributor

reggieriser commented Nov 7, 2019

Description

I noticed after a clean build that we had a couple generated-but-untracked mocks that were first referenced in #2820. Since we now check in generated code, I'm adding those in this PR.

Setup

Do a make clean mocks_generate followed by a git status to check if there are any additional changed/untracked mocks.

Code Review Verification Steps

  • Request review from a member of a different team.
@reggieriser reggieriser added the A-Team label Nov 7, 2019
@reggieriser reggieriser requested review from chrisgilmerproj and kimallen Nov 7, 2019
Copy link
Contributor

chrisgilmerproj left a comment

🚀

@reggieriser reggieriser merged commit 97b5b71 into master Nov 7, 2019
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@reggieriser reggieriser deleted the rr-add-missing-mocks branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.