Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate assets.go file #2972

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@reggieriser
Copy link
Contributor

reggieriser commented Nov 7, 2019

Description

It looks like our generated assets.go file reverted back to some old formatting (based on an earlier go-bindata version) in #2891. We fixed the formatting in #2888 and put a version check for go-bindata in with #2889, so all this stuff landed about the same time. I was getting a local diff on this, so this PR just regenerates the file with a recent go-bindata version.

Setup

Do a make clean server_generate and verify that git status shows no local changes.

Code Review Verification Steps

  • Request review from a member of a different team.
Copy link
Contributor

chrisgilmerproj left a comment

🚀

@reggieriser reggieriser merged commit 58bbf0a into master Nov 7, 2019
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@reggieriser reggieriser deleted the rr-fix-gen-assets branch Nov 7, 2019
@lynzt

This comment has been minimized.

Copy link
Contributor

lynzt commented Nov 7, 2019

@reggieriser thanks for noticing (and fixing) this... sorry for the extra work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.