Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the if statement placement for the github action #2974

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Nov 7, 2019

Description

I was looking at the Action repo https://github.com/hmarr/auto-approve-action and noticed the if statement was paired with the step and not the action. I'm wondering if this means it will stop running on non-dependabot branches. Figured it was worth a try.

The original PR #2919

@chrisgilmerproj chrisgilmerproj requested a review from mkrump Nov 7, 2019
@chrisgilmerproj chrisgilmerproj self-assigned this Nov 7, 2019
@chrisgilmerproj

This comment has been minimized.

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

chrisgilmerproj commented Nov 7, 2019

Ok, I think what's happening is that if you're not dependabot the action gets hung trying to run due to the original if statement placement. Now that I've moved it the action will run but nothing will happen.

@mkrump
mkrump approved these changes Nov 8, 2019
Copy link
Contributor

mkrump left a comment

Nice you fixed it! 🎊 . That's kinda odd that it just hangs, but now it's consistent with what's in the action author's repo https://github.com/hmarr/auto-approve-action.

@chrisgilmerproj chrisgilmerproj merged commit 983b298 into master Nov 8, 2019
16 checks passed
16 checks passed
Auto-approve dependabot PRs
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_update_github_approve_action branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.