Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chamber from Docker #3249

Merged
merged 27 commits into from Jan 3, 2020
Merged

Remove Chamber from Docker #3249

merged 27 commits into from Jan 3, 2020

Conversation

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Dec 20, 2019

Description

Instead of using chamber in Docker call out directly to SSM to get the secret names and inject them directly into the Task Definition.

This is something where deploying to experimental to test would make a lot of sense.

Requires:

Code Review Verification Steps

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Jira acceptance criteria been met for this change?

References

…e secret names and inject them directly into the Task Definition.
@chrisgilmerproj chrisgilmerproj requested review from mr337 and rdhariwal Dec 20, 2019
@chrisgilmerproj chrisgilmerproj self-assigned this Dec 20, 2019
@@ -29,6 +23,7 @@
}
],
"command": [],
"secrets": {{ .secrets }},

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Dec 20, 2019

Author Contributor

This is wonky I know. Because now the file isn't proper JSON. For now its excluded from the pre-commit check, which may bite us while we replace the template.

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

chrisgilmerproj commented Jan 1, 2020

Here's a problem:

An error occurred (ClientException) when calling the RegisterTaskDefinition operation: The secret name must be unique and not shared with any new or existing environment variables set on the container, such as 'DB_REGION'.

This means we need to make sure that the stuff in SSM and in the config/env/*.env files are unique against each other.

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

chrisgilmerproj commented Jan 2, 2020

…bash variables when calling renderer
@chrisgilmerproj chrisgilmerproj marked this pull request as ready for review Jan 2, 2020
This reverts commit f2b05b2.
@mr337
mr337 approved these changes Jan 3, 2020
Copy link
Contributor

mr337 left a comment

Excited about this PR! I think proof is in the pudding when it comes to the deployment. Lets 🚢

@chrisgilmerproj chrisgilmerproj merged commit 50afd48 into master Jan 3, 2020
16 checks passed
16 checks passed
auto-approve dependabot PRs
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_remove_chamber branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.