Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to prefer scan-alb-logs and also to fix bad command #3294

Merged
merged 3 commits into from Jan 13, 2020

Conversation

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Jan 8, 2020

Description

A few small fixes to the docs after reviewing a bug in production.

Try this:

scan-alb-logs prod 403 2020/01/06,2020/01/07,2020/01/08 office.move.mil
@gidjin
gidjin approved these changes Jan 9, 2020
Copy link
Contributor

gidjin left a comment

Thanks for updating the documentation! :shipit:

if [[ -n "${domainName}" ]]; then
big-cat "./tmp/*.app-${environment}.*.log.gz" | gunzip | read-alb-logs | jq -c ". | select( .elbStatusCode | startswith(\"${http_code}\")) | select(.domainName | startswith(\"${domainName}\")) | {requestType, timestamp, clientPort, elbStatusCode, targetStatusCode, domainName, request, actionsExecuted}"
else
big-cat "./tmp/*.app-${environment}.*.log.gz" | gunzip | read-alb-logs | jq -c ". | select( .elbStatusCode | startswith(\"${http_code}\")) | {requestType, timestamp, clientPort, elbStatusCode, targetStatusCode, domainName, request, actionsExecuted}"

This comment has been minimized.

Copy link
@gidjin

gidjin Jan 9, 2020

Contributor

I'm debating the -c I can't decide if I like it or not. Since we are limiting the number of attributes returned it's probably fine.

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Jan 13, 2020

Author Contributor

I think because its a limited set it works. But you're right that for a larger set it would make it hard to read.

@chrisgilmerproj chrisgilmerproj merged commit 23e4d4e into master Jan 13, 2020
16 checks passed
16 checks passed
auto-approve dependabot PRs
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_fix_search_for_application_errors branch Jan 13, 2020
@chrisgilmerproj chrisgilmerproj self-assigned this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.