Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to include link to new video #3302

Merged
merged 3 commits into from Jan 14, 2020

Conversation

@gidjin
Copy link
Contributor

gidjin commented Jan 10, 2020

Description

We recorded a meeting where we went through this document and demonstrated how it can be used.

Reviewer Notes

I left the original video linked as it may still be useful as it walks through some of the details underlying tools that make up the helpers used here. I'm happy to remove it if it is deemed not useful.

Setup

Read docs docs/how-to/search-for-application-errors.md

References

@gidjin gidjin requested review from chrisgilmerproj and jacquelineIO Jan 10, 2020
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - Do we want to put the videos together in their own section at the top? Not a big deal but might help. Otherwise this is great!

@gidjin

This comment has been minimized.

Copy link
Contributor Author

gidjin commented Jan 13, 2020

That's a good idea, I updated to have a videos section at the top with links to both videos.

@gidjin gidjin merged commit d38fe9d into master Jan 14, 2020
16 checks passed
16 checks passed
auto-approve dependabot PRs
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@gidjin gidjin deleted the gdjn_add_new_video_of_searching_logs branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.