Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cdn as a backend for assets in prod env #3323

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@rdhariwal
Copy link
Contributor

rdhariwal commented Jan 13, 2020

Description

Set backend flag to cdn instead of s3 so assets use cloudfront with a custom domain instead of s3. See this PR for additional context.

Reviewer Notes

You can confirm that prod env chamber already has the cloudfront key and cloudfront id. Run chamber list app-prod and look for cloud_front_key_id & cloud_front_private_key

Code Review Verification Steps

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Request review from a member of a different team.
  • Have the Jira acceptance criteria been met for this change?

References

@rdhariwal rdhariwal requested review from chrisgilmerproj and mr337 Jan 13, 2020
Copy link
Contributor

chrisgilmerproj left a comment

🚀 - Excellent! Make sure you notify on-call and product about this change when it gets merged.

@rdhariwal rdhariwal merged commit 8c09058 into master Jan 14, 2020
16 checks passed
16 checks passed
auto-approve dependabot PRs
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@rdhariwal rdhariwal deleted the rd-enable-cdn-prod-mb-378 branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.